Download player_head/skull texture even if no owner name present #162
Conversation
While the minecraft wiki currently states "Name: Username of owner. If missing or empty, the head appears as a Steve head.", this is observably incorrect.
```
minecraft:player_head[rotation=3]{SkullOwner:{Id:[I;-374731252,80498042,-1089022018,-75442154],Properties:{textures:[{Value:"eyJ0ZXh0dXJlcyI6eyJTS0lOIjp7InVybCI6Imh0dHA6Ly90ZXh0dXJlcy5taW5lY3JhZnQubmV0L3RleHR1cmUvODI5ZTg4NThlNGUwYzE3NTEzMTNlZjU4YWRhZjM0YzIxNjk4N2Y3NzhiMmI5ODQ4MWU5ZWNiOTFhNzE5NCJ9fX0="}]}}}
```
```
minecraft:player_head[rotation=13]{SkullOwner:{Id:[I;553703739,-2015082768,-1803964419,-471486417],Properties:{textures:[{Value:"ewogICJ0aW1lc3RhbXAiIDogMTYyNjQyMTc1MTcxMiwKICAicHJvZmlsZUlkIiA6ICIyMTAwZDkzYjg3ZTQ0NmYwOTQ3OWFmZmRlM2U1YjAyZiIsCiAgInByb2ZpbGVOYW1lIiA6ICJEaXZpbmVBcXVhU2FtYSIsCiAgInRleHR1cmVzIiA6IHsKICAgICJTS0lOIiA6IHsKICAgICAgInVybCIgOiAiaHR0cDovL3RleHR1cmVzLm1pbmVjcmFmdC5uZXQvdGV4dHVyZS9iOGRkM2IwMTVjMmQxY2VmNmY2M2ExMDUzY2ZiZTdmOWY3MTRlYjFmMGZmMDdiYmQ1YjI0YzNmMGViODZhMmYyIiwKICAgICAgIm1ldGFkYXRhIiA6IHsKICAgICAgICAibW9kZWwiIDogInNsaW0iCiAgICAgIH0KICAgIH0KICB9Cn0="}]},Name:"DivineAquaSama"}}
```
```
minecraft:player_head[rotation=11]{}
```
All three of the above are valid player skulls but only the third one renders with no texture in-game. The first one contains a texture value with no name while the second one does contain a name.
This commit fixes the incorrect assumption that any valid textured player head has a `Name` tag as well. The downloaded texture name will use the player name if present as `player_<name>.png`. If no name is present, it will fall back to using the textures.minecraft.net's texture ID from the URL decoded from the B64 texture url.
|
For what it's worth I tried tinkering a bit more on what constitutes a valid textured Using the following as the base "full command" in a command block: I modified the command in various ways to see if a valid textured head would be created While I haven't bothered trying to modify the base64 encoded json value's contents, at the very least the condition for rendering a textured player head seems to be that so long as either |
| name = ((TAG_String)nameNbt).value; | ||
| } else { | ||
| String url = extractSkullOwnerTextureUrl(textureB64); | ||
| name = url.substring(url.lastIndexOf('/') + 1); |
There was a problem hiding this comment.
Trailing slashes are considered invalid on textures.minecraft.net
See:
http://textures.minecraft.net/texture/b8dd3b015c2d1cef6f63a1053cfbe7f9f714eb1f0ff07bbd5b24c3f0eb86a2f2
vs
http://textures.minecraft.net/texture/b8dd3b015c2d1cef6f63a1053cfbe7f9f714eb1f0ff07bbd5b24c3f0eb86a2f2/
|
Nice work, thanks for the PR. I'll try and quickly test it out soon. |
Hi there.
I'm really not much of a Java person but I did want to fix a small functionality bug that wasn't captured as part of #156's fix. Please let me know if there are any "Java-isms" I'm not following or any other feedback. Happy to revise this PR/add evidence if necessary.
While the minecraft wiki currently states "Name: Username of owner. If missing or empty, the head appears as a Steve head.", this is observably incorrect.
Below are three valid player skulls where only the third one renders as the default steve head. The first one contains a texture value but no name while the second one contains both name and texture value. (Data captured via F3+I in-game)
This commit fixes the incorrect assumption that any valid textured player head has a
Nametag as well. The downloaded texture name will use the player name if present asplayer_<name>.png. If no name is present, it will fall back to using the textures.minecraft.net's texture ID from the URL decoded from the B64 texture url asplayer_<tex_id>.png.FWIW, I'm getting these skulls via a Bukkit/Spigot plugin - Head Database. Presumably the plugin doesn't bother adding the owner name in the NBT data since the skulls render fine without it.