Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double all standalone faces and fix chain model #155

Merged
merged 2 commits into from
May 1, 2021

Conversation

pschichtel
Copy link
Contributor

  • Standalone faces are problematic, when the rendering engine applies backface culling, leading to one-sided objects. I introduce a second face with reversed vertex winding order.
  • I introduce a Chain model that properly scales the model and correctly maps the texture.

* Standalone faces are problematic, when the rendering engine applies backface culling, leading to one-sided objects. I introduce a second face with reversed vertex winding order.
* I introduce a Chain model that properly scales the model and correctly maps the texture.
@pschichtel
Copy link
Contributor Author

image
that's how this looks in unity

@mmdanggg2
Copy link
Collaborator

Thanks for the patch. If we're adding it, I think the doubled surfaces should be an optional setting. It seems like a hack just to fake backsided rendering. Most programs can or do have backfaces enabled so this should be disabled by default.

@pschichtel
Copy link
Contributor Author

@mmdanggg2 I totally agree. I quickly fixed this because I intent do use your tool during the Ludum Dare 48 over the weekend in conjunction with Unity. So after the weekend I can work on making it optional.

Btw I noticed that that your project does not explicitly state a license, is that intentional?

…aces

This commit also adds reversing the UVs
@pschichtel
Copy link
Contributor Author

@mmdanggg2 Added the option to enable/disable the backface generation and it also reverses the UVs now (e.g. plant backfaces showed rotated textures)

The tool proved to be pretty effective: https://ldjam.com/events/ludum-dare/48/drillromantik

@mmdanggg2 mmdanggg2 merged commit c1c2250 into jmc2obj:master May 1, 2021
@mmdanggg2
Copy link
Collaborator

Many thanks. I've just renamed a couple things. Good luck with the Ludum Dare!

@mmdanggg2 mmdanggg2 mentioned this pull request May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants