Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of PostgreSQL's Raw Encryption #120

Closed
wants to merge 5 commits into from

Conversation

aquajach
Copy link

@aquajach aquajach commented Aug 9, 2016

Why PostgreSQL's Raw Encryption?

Although in the PostgreSQL's documentation the raw encryption is said as less recommended than pgp, it has its own advantages. In database encryption, flexibility and security are two sides on a balance. If a project with PostgreSQL requires both encryption and quick search function, the raw encryption seems the only choice. Searching in pgp from 1,000 records brings a major performance issue.

I love PostgreSQL and crypt_keeper (esp. its simplicity) to do encryption, and don't want to give up any of them.

@itspriddle
Copy link
Collaborator

Hey @aquajach, thanks for the PR 👍, just a couple small things:

  1. I've just added an option to silence log output in Allow silencing logging completely #121. Can you add return if CryptKeeper.silence_logs? && payload =~ filter to L18 of lib/crypt_keeper/log_subscriber/postgres_raw.rb and a spec to spec/log_subscriber/postgres_pg_raw_spec.rb to verify that behavior? An example of the spec for existing log subscribers is in Allow silencing logging completely #121
  2. The Travis CI build is failing due to appraisal. Can you pull master, rebase your branch, and then run bundle exec appraisal and check in the gemfiles generated under gemfiles/?

Thanks again!

@aquajach
Copy link
Author

aquajach commented Sep 5, 2016

@itspriddle Just updated accordingly and the build is restored

@itspriddle
Copy link
Collaborator

👍

@jmazzi any thoughts?

@jmazzi
Copy link
Owner

jmazzi commented Jan 17, 2018

@aquajach @itspriddle wow, somehow missed this PR a while ago. I'm ok with it if there's still interest here.

@itspriddle
Copy link
Collaborator

@jmazzi I will defer to @aquajach. It's not something we use or I've seen requested outside of this PR. I'd be fine adding it as long as there is some usage in the wild.

@aquajach if you're still keen to see this added, please let us know. If you can speak to any issues you may have come across using it that would be especially helpful!

@itspriddle
Copy link
Collaborator

Closing – please feel free to reopen if this is something you are still looking to see added. Thanks!

@itspriddle itspriddle closed this Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants