Updates to Logging Middleware #1974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logging middleware now tracks and logs request duration alongside other request information. Duration is measured using time.perf_counter() and displayed in milliseconds, following the same pattern as the existing timing middleware. Co-authored-by: William Easton <strawgate@users.noreply.github.com>
strawgate
changed the title
|
We should probably also remove the timestamp (or make it optional) |
strawgate
changed the title
strawgate
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR updates the logging middleware to track request duration, update logger namespacing, and improve error handling. The changes align with issue #1973 and enhance the observability of the FastMCP server.
Key changes include:
- Added request duration tracking using
time.perf_counter()and reporting in milliseconds - Updated logger names to use the
fastmcp.middleware.*namespace pattern - Improved error logging to include error type information in structured format
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/fastmcp/server/middleware/logging.py |
Core logging middleware implementation with duration tracking, updated namespacing, and improved error handling |
tests/server/middleware/test_logging.py |
Updated test suite to validate new duration tracking, logger namespacing, and structured logging improvements |
jlowin
approved these changes
Oct 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up the tests a little bit with a helper function for extracting logs from caplog
Closes #1973