Add state dict to Context (#1118) #1160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mukulmurthy
commented
Jul 16, 2025
Comment on lines
+98
to
+99
| is created (nested contexts), it inherits a copy of its parent's state, ensuring | ||
| that modifications in child contexts don't affect parent contexts. |
There was a problem hiding this comment.
Discussed the semantics of this a little in the PR description. If you think child state should affect the parent, we could do it that way.
mukulmurthy
changed the title
state dict to Context (#1118)
jlowin
requested changes
Jul 18, 2025
jlowin
approved these changes
Jul 22, 2025
jlowin
added
the
enhancement
|
Thank you for fixing up and merging @jlowin! |
jlowin
added
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an internal dict
stateinsideContextthat can be interacted with via theget_state_valueandset_state_valueAPIs. This is intended for middleware or other stages of a request to pass information back and forth, since there is not an easy way to do that right now without using ContextVars.When a context is created, it inherits state from its parents. What that means is that:
Proposed in #1118. Tested with new tests in test_context.py.