Skip to content

Issue 285 fix #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Issue 285 fix #314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1cc844
add screenshot of cause of bug
MordechaiShebuel Jan 21, 2021
3e7d109
removed screenshot here, not necessary
MordechaiShebuel Jan 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/verify/branches_arent_just_for_birds.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,10 @@ module.exports = function verifyBranchesChallenge (repopath) {

function findFile () {
// see if user is already within /contributors
if (repopath.match('contributors')) {
if (repopath.match('./contributors')) {
check(repopath)
} else {
check(path.join(repopath, '/contributors/'))
check(path.join(repopath, './contributors/'))
}

function check (userspath) {
Expand Down
2 changes: 1 addition & 1 deletion resources/contents/en-US/challenges/7_branches_arent_just_for_birds.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ <h3>Step: Create a new file</h3>
'username' is your username. For instance, "add-jlord.txt".
</li>
<li>Then, just write your GitHub username in it, that's it and that's all. For instance, I'd type 'jlord'.</li>
<li>Save this file in the 'contributors' folder in Patchwork: <strong>Patchwork/contributors/add-yourusername.txt</strong>
<li>Save this file in the 'contributors' folder in Patchwork: <strong>contributors/add-yourusername.txt</strong>
</li>
<li>Next, check in your changes (see below).</li>
</ul>
Expand Down