Fix cr/lf support in dumb terminals (#877)

jline · Oct 24, 2023 · 421bf59 · 421bf59
1 parent 2af16d8
commit 421bf59
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/reader/src/main/java/org/jline/reader/impl/LineReaderImpl.java b/reader/src/main/java/org/jline/reader/impl/LineReaderImpl.java
@@ -640,11 +640,6 @@ public String readLine(String prompt, String rightPrompt, MaskingCallback maskin
                     if (isSet(Option.AUTO_FRESH_LINE)) callWidget(FRESH_LINE);
                     if (isSet(Option.MOUSE)) terminal.trackMouse(Terminal.MouseTracking.Normal);
                     if (isSet(Option.BRACKETED_PASTE)) terminal.writer().write(BRACKETED_PASTE_ON);
-                } else {
-                    // For dumb terminals, we need to make sure that CR are ignored
-                    Attributes attr = new Attributes(originalAttributes);
-                    attr.setInputFlag(Attributes.InputFlag.IGNCR, true);
-                    terminal.setAttributes(attr);
                 }
 
                 callWidget(CALLBACK_INIT);

diff --git a/terminal/src/main/java/org/jline/terminal/TerminalBuilder.java b/terminal/src/main/java/org/jline/terminal/TerminalBuilder.java
@@ -459,6 +459,11 @@ private Terminal doBuild() throws IOException {
                 type = getDumbTerminalType(dumb, systemStream);
                 terminal = new DumbTerminalProvider()
                         .sysTerminal(name, type, false, encoding, nativeSignals, signalHandler, paused, systemStream);
+                if (OSUtils.IS_WINDOWS) {
+                    Attributes attr = terminal.getAttributes();
+                    attr.setInputFlag(Attributes.InputFlag.IGNCR, true);
+                    terminal.setAttributes(attr);
+                }
             }
         } else {
             for (TerminalProvider provider : providers) {