Revert CRD status exception and remove status from Seldon CRD (kubefl…

…ow#1389)
jlewi · Jul 16, 2020 · 430b4d0 · 430b4d0
1 parent ac14931
commit 430b4d0
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 23 deletions.
diff --git a/seldon/seldon-core-operator/base/resources.yaml b/seldon/seldon-core-operator/base/resources.yaml
@@ -4238,12 +4238,6 @@ spec:
   - name: v1alpha3
     served: true
     storage: false
-status:
-  acceptedNames:
-    kind: ''
-    plural: ''
-  conditions: []
-  storedVersions: []
 ---
 # Source: seldon-core-operator/templates/clusterrole_seldon-manager-role.yaml
 apiVersion: rbac.authorization.k8s.io/v1

diff --git a/....k8s.io_v1beta1_customresourcedefinition_seldondeployments.machinelearning.seldon.io.yaml b/....k8s.io_v1beta1_customresourcedefinition_seldondeployments.machinelearning.seldon.io.yaml
@@ -6920,9 +6920,3 @@ spec:
   - name: v1alpha3
     served: true
     storage: false
-status:
-  acceptedNames:
-    kind: ""
-    plural: ""
-  conditions: []
-  storedVersions: []
diff --git a/....k8s.io_v1beta1_customresourcedefinition_seldondeployments.machinelearning.seldon.io.yaml b/....k8s.io_v1beta1_customresourcedefinition_seldondeployments.machinelearning.seldon.io.yaml
@@ -6922,9 +6922,3 @@ spec:
   - name: v1alpha3
     served: true
     storage: false
-status:
-  acceptedNames:
-    kind: ""
-    plural: ""
-  conditions: []
-  storedVersions: []
diff --git a/tests/validate_resources_test.go b/tests/validate_resources_test.go
@@ -229,11 +229,6 @@ func TestValidK8sResources(t *testing.T) {
 				t.Errorf("Path %v; resource %v; has version and kind %v which should be changed to %v", path, m.Name, vAndK, v)
 			}
 
-			//Skip Custom resource Definitions as they can have a status field
-			if m.Kind == "CustomResourceDefinition" {
-				continue
-			}
-
 			// Ensure status isn't set
 			f := n.Field("status")