fix: accept responses path appended to chat completions base#932
Open
lawyer112 wants to merge 1 commit into
Open
fix: accept responses path appended to chat completions base#932lawyer112 wants to merge 1 commit into
lawyer112 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/v1/chat/completions/v1/responsesas a compatibility path for clients that append the Responses endpoint to a Chat Completions base URL./v1/chat/completions/v1/responses/compactwith the same compatibility behavior.404 endpoint not supported.Why
Some clients/configurations can accidentally use
http://host:port/v1/chat/completionsas the base URL and then append/v1/responses, producing:In local reproduction,
/v1/responsesworked while this appended path consistently returned 404. This compatibility route avoids failing those requests and keeps them within the Responses handling path.Related: #908
Testing