fix(test): isolate Codex account storage#816
Open
Disaster-Terminator wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Codex account tests create mock accounts such as
demo@example.com,access@example.com, andauth-access@example.com. On Windows, overridingHOMEandCODEX_HOMEis not enough to makedirs::home_dir()resolve into the test directory, so tests can write those mock accounts into the real user data directory at.antigravity_cockpit/codex_accounts.json.This keeps the production path unchanged and only enables the override for test builds.
Test Plan
cargo test -p cockpit-core --lib test_env_guard_redirects_codex_account_storagecargo test -p cockpit-tools --lib test_env_guard_redirects_codex_account_storagecargo test -p cockpit-core --lib upsert_cargo test -p cockpit-tools --lib upsert_cargo test -p cockpit-core --lib modules::codex_account::testscargo test -p cockpit-tools --lib modules::codex_account::testsgit diff --checkNote:
cargo fmt --checkcurrently reports pre-existing formatting drift in unrelated files outside this PR.