Replace FRect2D with Rect2f #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be ready for merge now. |
knuesel
force-pushed
the
refactor-f0-rect
branch
from
ff5c587 to
2a441d1
Compare
|
@jkrumbiegel I forced-pushed a fix following the latest changes on master. Would it be possible to merge this soon so we can also merge the type renames in Makie? |
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
=======================================
Coverage 87.00% 87.00%
=======================================
Files 10 10
Lines 1170 1170
=======================================
Hits 1018 1018
Misses 152 152
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches to new GeometryBasics type names from JuliaGeometry/GeometryBasics.jl#97.