provider: split travis linting into two steps and disable stati… (has…

…hicorp#4349)

.golangci-travisrest.yml

@@ -0,0 +1,35 @@
+run:
+  deadline: 30m10s
+  modules-download-mode: vendor
+
+issues:
+  max-per-linter: 0
+  max-same-issues: 0
+
+linters:
+  disable-all: true
+  enable:
+    - deadcode
+    - errcheck
+    - gofmt
+    - goimports
+    - gosimple
+    - govet
+    - ineffassign
+    - interfacer
+    - nakedret
+    - misspell
+    - structcheck
+    - typecheck
+    - unused
+    - unconvert
+    - varcheck
+    - vet
+    - vetshadow
+
+linters-settings:
+  errcheck:
+    ignore: github.com/hashicorp/terraform/helper/schema:ForceNew|Set,fmt:.*,io:Close
+  misspell:
+    ignore-words:
+      - hdinsight

.golangci.yml

@@ -33,4 +33,4 @@ linters-settings:
     ignore: github.com/hashicorp/terraform/helper/schema:ForceNew|Set,fmt:.*,io:Close
   misspell:
     ignore-words:
-      - hdinsight
+      - hdinsight

.travis.yml

@@ -27,8 +27,8 @@ matrix:
   allow_failures:
     - go: tip
   include:
-    - name: "make lint"
-      script: GOGC=20 make lint
+    - name: "make lintrest"
+      script: GOGC=20 make lintrest
     - name: "make tflint"
       script: make tflint
     - name: "make test"

GNUmakefile

@@ -40,6 +40,16 @@ lint:
 	@echo "==> Checking source code against linters..."
 	golangci-lint run ./...
 
+# we have split off static check because it causes travis to fail with an OOM error
+lintstatic:
+	@echo "==> Checking source code against static check linters..."
+	(while true; do sleep 300; echo "(Hey travis! I'm still alive and linting)"; done) & PID=$$!; echo $$PID; \
+	golangci-lint run ./... -v --no-config --concurrency 1 --deadline=30m10s --disable-all --enable=staticcheck; ES=$$?; kill -9 $$PID; exit $$ES
+
+lintrest:
+	@echo "==> Checking source code against linters..."
+	golangci-lint run ./... -v --config .golangci-travisrest.yml
+
 tflint:
 	@echo "==> Checking source code against terraform provider linters..."
 	@tfproviderlint \