Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not store refresh token, if empty. #349

Merged
merged 4 commits into from
Nov 12, 2024
Merged

fix: do not store refresh token, if empty. #349

merged 4 commits into from
Nov 12, 2024

Conversation

jkroepke
Copy link
Owner

What this PR does / why we need it

#338 (comment)

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer

Particularly user-facing changes

Checklist

Complete these before marking the PR as ready to review:

  • DCO signed
  • The PR title has a summary of the changes
  • The PR body has a summary to reflect any significant (and particularly user-facing) changes introduced by this PR

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.17%. Comparing base (1b04674) to head (231a407).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/oauth2/refresh.go 61.53% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #349      +/-   ##
==========================================
+ Coverage   81.82%   82.17%   +0.35%     
==========================================
  Files          51       51              
  Lines        3152     3153       +1     
==========================================
+ Hits         2579     2591      +12     
+ Misses        437      428       -9     
+ Partials      136      134       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke jkroepke added the 🐞 bug Something isn't working label Nov 12, 2024
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke jkroepke merged commit 1d34340 into main Nov 12, 2024
7 checks passed
@jkroepke jkroepke deleted the fix-refresh branch November 12, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing required parameter: refresh_token
1 participant