Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable sloglint #342

Merged
merged 5 commits into from
Nov 1, 2024
Merged

chore: enable sloglint #342

merged 5 commits into from
Nov 1, 2024

Conversation

jkroepke
Copy link
Owner

@jkroepke jkroepke commented Nov 1, 2024

What this PR does / why we need it

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

  • fixes #

Special notes for your reviewer

Particularly user-facing changes

Checklist

Complete these before marking the PR as ready to review:

  • DCO signed
  • The PR title has a summary of the changes
  • The PR body has a summary to reflect any significant (and particularly user-facing) changes introduced by this PR

Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de>
@jkroepke jkroepke added the chore small nits label Nov 1, 2024
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 82.67%. Comparing base (1dc2a22) to head (693f350).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/oauth2/providers/generic/user.go 33.33% 4 Missing ⚠️
internal/oauth2/refresh.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #342      +/-   ##
==========================================
+ Coverage   82.50%   82.67%   +0.17%     
==========================================
  Files          50       50              
  Lines        3081     3083       +2     
==========================================
+ Hits         2542     2549       +7     
+ Misses        408      404       -4     
+ Partials      131      130       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de>
Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de>
Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de>
Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de>
@jkroepke jkroepke merged commit ea55dbf into main Nov 1, 2024
7 checks passed
@jkroepke jkroepke deleted the sloglint branch November 1, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore small nits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant