Skip to content

Commit

Permalink
[iOS] Enable skipped System.Threading tests (dotnet#73498)
Browse files Browse the repository at this point in the history
* [iOS] Enable skipped System.Threading tests

Fixes dotnet#51400

* Redisable 60583 and remove added newline

Co-authored-by: Steve Pfister <steve.pfister@microsoft.com>
Co-authored-by: mdh1418 <mitchhwang1418@gmail.com>
  • Loading branch information
3 people authored Aug 8, 2022
1 parent 495a620 commit 326af2c
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,6 @@ public void WaitHandleWaitAny()
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/51400", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
public void PingPong()
{
using (AutoResetEvent are1 = new AutoResetEvent(true), are2 = new AutoResetEvent(false))
Expand Down
2 changes: 0 additions & 2 deletions src/libraries/System.Threading/tests/ExecutionContextTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ public static void DisposeTest()
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/51400", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
public static void FlowTest()
{
ThreadTestHelpers.RunTestInBackgroundThread(() =>
Expand Down Expand Up @@ -170,7 +169,6 @@ public static void FlowTest()
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/51400", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
public static void CaptureThenSuppressThenRunFlowTest()
{
ThreadTestHelpers.RunTestInBackgroundThread(() =>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,6 @@ public void WaitHandleWaitAny()
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/51400", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
public void PingPong()
{
using (ManualResetEvent mre1 = new ManualResetEvent(true), mre2 = new ManualResetEvent(false))
Expand Down
7 changes: 0 additions & 7 deletions src/libraries/System.Threading/tests/ReaderWriterLockTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@ public static void InvalidLockCookieTest()
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/51400", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
public static void BasicLockTest()
{
var trwl = new TestReaderWriterLock();
Expand Down Expand Up @@ -511,7 +510,6 @@ public static void WaitingReadersTest()
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/51400", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
public static void WaitingWritersTest()
{
var trwl = new TestReaderWriterLock();
Expand Down Expand Up @@ -543,7 +541,6 @@ public static void WaitingWritersTest()
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/51400", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
public static void ReadersWaitingOnWaitingWriterTest()
{
var trwl = new TestReaderWriterLock();
Expand Down Expand Up @@ -594,7 +591,6 @@ public static void ReadersWaitingOnWaitingWriterTest()
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/51400", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
public static void ReadersWaitingOnWaitingUpgraderTest()
{
var trwl = new TestReaderWriterLock();
Expand Down Expand Up @@ -648,7 +644,6 @@ public static void ReadersWaitingOnWaitingUpgraderTest()
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/51400", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
public static void WaitingUpgradersTest()
{
var trwl = new TestReaderWriterLock();
Expand Down Expand Up @@ -694,7 +689,6 @@ public static void WaitingUpgradersTest()
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/51400", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
public static void AtomicRecursiveReaderTest()
{
var trwl = new TestReaderWriterLock();
Expand All @@ -721,7 +715,6 @@ public static void AtomicRecursiveReaderTest()
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/51400", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
public static void AtomicDowngradeTest()
{
var trwl = new TestReaderWriterLock();
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.Threading/tests/SemaphoreTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,6 @@ public void CanWaitWithoutBlockingForReleasedCount()

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/49890", TestPlatforms.Android)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/51400", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
public void AnonymousProducerConsumer()
{
using (Semaphore s = new Semaphore(0, int.MaxValue))
Expand Down

0 comments on commit 326af2c

Please sign in to comment.