Conversation
…torage and example ingress
|
Hm, this feels like it's an adaptation of something that is maybe working for you, but I wonder if it's a good example to be setting. I haven't run this yet but some things that stand out to me from a quick glance over lunch:
I'm open to doing k8s but I'd like it to be a pretty shiny example of a good deployment rather than an adaptation of something that mostly-works. What do you think? |
1852da2 to
7d5cfde
Compare
|
I'm going to close this for now, but feel free to take another pass if you're still interested in introducing this! And apologies for not accepting as-is -- for config examples, it's important to me that they be super readily usable for users and pretty polished/best-practices. |
|
sorry, was busy last week and had no time reviewing your comment. thanks for the feedback, i am trying to answer your points but in general this deployment is the most generic deployment suitable for most of the classic clusters out there but with some commented out examples to fit even if there are some deviations:
yes, that's on me. i am going to remove the second one.
that depends on ether the cluster as a
RWO is correct and MUST be used for databases, otherwise (RWM) multiple instances would be able to mount the same volume which would end catastropic ;)
can you explain what's confusing about the comment? (you mean probably line 99, right?)
good point. I can remove it from the pvc but then everything in the venv needs to be build after every pod restart. is that okay? |
| volumeName: local-meshcore | ||
| # storageClassName: 'generic' # optional: set storageClass | ||
| accessModes: | ||
| - ReadWriteMany |
|
Yeah mainly around the version confusion.
the Docker image already has all dependencies installed at build time. uv run does a quick sync on startup (~400ms), but the actual application code and dependencies are baked into the image. Persisting the venv on the PVC means stale dependencies can survive across image upgrades. I've begun integrating some k3s tests into my exhaustive testing scenarios and this is the deployment I've been testing with, with the kind of comments I'd like to see to help new users get adapted into their env: |
Adds a simple Kubernetes Deployment with persistent storage and an ingress.