Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup codebase #520

Merged
merged 6 commits into from
Jun 10, 2022
Merged

Cleanup codebase #520

merged 6 commits into from
Jun 10, 2022

Conversation

davidgoli
Copy link
Collaborator

  • Exports datetime helper
  • Replaces all usage of new Date(Date.UTC(..)) with datetime
  • Converts dateutils from a namespace to a module

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2022

Codecov Report

Merging #520 (e89b5d2) into master (cb1dcfd) will increase coverage by 0.00%.
The diff coverage is 97.52%.

@@           Coverage Diff           @@
##           master     #520   +/-   ##
=======================================
  Coverage   88.69%   88.70%           
=======================================
  Files          29       29           
  Lines        2026     2027    +1     
  Branches      756      756           
=======================================
+ Hits         1797     1798    +1     
  Misses        229      229           
Impacted Files Coverage Δ
src/cache.ts 92.72% <75.00%> (-0.26%) ⬇️
src/dateutil.ts 97.01% <96.96%> (+0.13%) ⬆️
src/datetime.ts 90.00% <100.00%> (ø)
src/datewithzone.ts 96.15% <100.00%> (ø)
src/index.ts 100.00% <100.00%> (ø)
src/iter/index.ts 97.22% <100.00%> (ø)
src/iter/poslist.ts 89.65% <100.00%> (ø)
src/iterinfo/index.ts 98.01% <100.00%> (ø)
src/iterinfo/yearinfo.ts 95.58% <100.00%> (ø)
src/iterset.ts 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb1dcfd...e89b5d2. Read the comment docs.

@davidgoli davidgoli merged commit 6de8945 into master Jun 10, 2022
@davidgoli davidgoli deleted the cleanup branch June 10, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants