fix: resolve circular import #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RRule in rrulset.ts ends up being undefined because the root index is being loaded while files such as nlp/totext.ts depend on the root index while rrule.ts depends on nlp/index.ts. Then, at one point the execution proceeds even though the root index has not fully loaded.
|
A screenshot of the error where it points to the line |
|
Follow up to #444 regarding the circular imports. |
|
It would be awesome to have this merged/released |
Closed
|
Any news on this one?. this seems to be the solution for rollup and vite builds |
|
Hello please merge this RRule does not work with vite. |
|
Can someone update or merge this? we need it for sveltekit. |
|
This project used to have CI, where did it go? |
davidgoli
approved these changes
Mar 3, 2022
|
@davidgoli Thank you for merging! Highly appreciated 🙏🏽 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RRule in rrulset.ts ends up being undefined because the root index is being
loaded while files such as nlp/totext.ts depend on the root index while
rrule.ts depends on nlp/index.ts. Then, at one point the execution
proceeds even though the root index has not fully loaded.
Thanks for contributing to
rrule!To submit a pull request, please verify that you have done the following:
mastercommitaddressing