Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect source paths in generated source maps (#303) #455

Merged
merged 1 commit into from
Feb 21, 2021

Conversation

jkronborg
Copy link
Contributor

Fixes the incorrect source paths in generated source maps, which was reported in #303 but never fixed.

The issue can be reproduced using @anthwinter's original repro.


Thanks for contributing to rrule!

To submit a pull request, please verify that you have done the following:

  • Merged in or rebased on the latest master commit
  • Linked to an existing bug or issue describing the bug or feature you're
    addressing
  • Written one or more tests showing that your change works as advertised

Fixes incorrect source paths in generated source maps.
@jkbrzt jkbrzt merged commit 286422d into jkbrzt:master Feb 21, 2021
@jkronborg
Copy link
Contributor Author

@jakubroztocil Thanks for the merge. Any chance this fix can be released? 🙏

@justinbhopper
Copy link

@jakubroztocil Do you plan on releasing this fix? It has been unreleased for 4+ months now, and it would be most welcome.

@Kaishley
Copy link

@jakubroztocil Bump for release please 🙏

@davidgoli
Copy link
Collaborator

@Kaishley this was released in v2.6.9

@elikmiller
Copy link

I upgraded to v2.6.9 and noticed the paths were still incorrect.

When I install this package in my project I noticed that the node_modules/rrule/src directory is not present. I fixed this for myself by including src in the array of files configured in this project's package.json.

@shivamjjha
Copy link

@elikmiller how did you do that ?

@elikmiller
Copy link

@elikmiller how did you do that ?

I forked this repo, made my changes, and rebuilt the project.

You can see the latest commits I added https://github.com/elikmiller/rrule here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants