Skip to content

Conversation

@Stonelinks
Copy link

hey there,

just some small changes i found necessary when using this. thanks for the plugin!

@jk-gan jk-gan self-assigned this Jun 4, 2020
@jk-gan jk-gan added the enhancement New feature or request label Jun 4, 2020
Comment on lines +79 to +84
} catch (error) {
state.action = { type: action.type };
state.before = { error };
state.after = { error };
currentConnection.send('actionDispatched', state);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that the error information in flipper is converted into another form of object which is not informative. I suggest to have one more field for the error message.

Suggested change
} catch (error) {
state.action = { type: action.type };
state.before = { error };
state.after = { error };
currentConnection.send('actionDispatched', state);
}
} catch (error) {
state.action = { type: action.type };
state.before = { error, message: error.toString() };
state.after = { error, message: error.toString() };
currentConnection.send('actionDispatched', state);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants