Link Phosphorous design system into global.css#74
Merged
Conversation
Add jk.com-design-system as a git submodule (vendor/phosphorous, pinned to main / v1.0.0) and replace the design tokens and utility classes inlined in global.css with a single @import of its styles.css, per INTEGRATION.md. @theme becomes @theme inline so Tailwind's generated utilities (hover:text-cyan, font-heading, etc.) read the tokens straight from the design system instead of duplicating values. Keeps site-specific pieces that have no design-system equivalent: glitch-1/glitch-2 keyframes, the gradient-text pulse animation, .animate-on-scroll, .skip-link, and .prose (blog content). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FG2snAikKk6YLFnxTS85ik
Without submodules: true, vendor/phosphorous is an empty directory in CI and the @import in global.css fails to resolve. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FG2snAikKk6YLFnxTS85ik
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to make the Phosphorous design system the single source of truth for global design tokens and shared utility classes by importing it into global.css and mapping tokens into Tailwind’s CSS-first @theme inline configuration. It also updates the deploy workflow to ensure submodules are checked out in CI.
Changes:
- Import Phosphorous design-system CSS from
vendor/phosphorous/styles.cssand remove locally inlined design tokens / shared utility classes fromsrc/styles/global.css. - Switch Tailwind token configuration to
@theme inlineso generated utilities resolve values from design-system:rootcustom properties. - Enable submodule checkout in the deploy workflow.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/styles/global.css |
Replaces local tokens/utilities with a design-system import + @theme inline, retaining a small set of site-specific animations/utilities. |
.gitmodules |
Adds the Phosphorous design system as a git submodule under vendor/phosphorous. |
.github/workflows/deploy.yml |
Updates checkout step to fetch submodules in CI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
9
to
+10
| @import "tailwindcss"; | ||
| @import "../../vendor/phosphorous/styles.css"; |
Comment on lines
+92
to
101
| @media (prefers-reduced-motion: reduce) { | ||
| .gradient-text { | ||
| animation: none; | ||
| } | ||
| /* Suppress Tailwind's bounce utility (used in Hero's scroll indicator) */ | ||
| .animate-bounce { | ||
| animation: none; | ||
| } | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jk-dot-com/jk.com-design-systemas a git submodule atvendor/phosphorous(pinned tomain), per that repo'sINTEGRATION.mdsrc/styles/global.csswith a single@import "../../vendor/phosphorous/styles.css"@theme→@theme inlineso Tailwind's generated utilities (hover:text-cyan,font-heading,duration-normal, …) read tokens straight from the design system's:rootcustom properties instead of duplicating hex/value literalsglobal.cssshrinks from 464 to 214 lines; the design system is now the single source of truth for colors, typography, spacing, and shared utility classes (.btn,.chip,.glow-border,.iridescent,.section-label,.gradient-text,.grid-overlay)Kept in
global.css— no design-system equivalent (dropping would change rendering)@keyframes glitch-1/glitch-2— used directly byHero.svelteand404.astro; the design system only ships prefixedphos-glitch-1/2for its own internal use.gradient-text'stext-staticpulse animation — the design system's.gradient-textis static; re-applied the site's existing animation on top of the design-system class.animate-on-scroll,.skip-link,.prose(blog content styling) — not shipped by the design system at allDropped as dead code (not referenced anywhere in
src/)flicker,scan-line,fade-up,pulse-glowkeyframes.iridescentrule — superseded by the design system's version, which is intentionally more pronounced per its ownCHANGELOG.mdTest plan
global.csswith@tailwindcss/cliand confirmed.hover\:text-cyan,.font-heading,.glow-border, and.gradient-text(with the re-applied animation) all generate correctly against the design system's tokens.prosestyling)Generated by Claude Code