Skip to content

Xendit #0008 - Security #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2020
Merged

Xendit #0008 - Security #8

merged 2 commits into from
Oct 28, 2020

Conversation

jjjimenez100
Copy link
Owner

Background

Please implement the following security controls for your system:

  1. Ensure the system is not vulnerable to SQL injection
  2. [BONUS] Implement an additional security improvement of your choice

Acceptance Criteria

  1. A pull request against master of your fork with:
    1. Changes to the code
    2. Tests ensuring the vulnerability is addressed

Description
The PR adds the helmet dependency for adding in http headers for security. Test cases are also included within api.test.js
image

Other security items added from previous pull requests:

  • Input validation on endpoints, with corresponding test cases
  • Using parameter placeholders on SQLite3 to prevent SQL Injection
  • Logging all errors to disk file

@jjjimenez100 jjjimenez100 merged commit 19789b4 into master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant