cleanup modules checking code #14
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dear JJgomera,
I thing this project is quite interesting and I would like to contribute to it. Even though I do not think that I will having much time to contribute regularly to it but I will try to do my best. Below is little description about my first pull request:
I did two things in this pull request:
first I was getting error when I run the program "it is about the global variable in the mainWindow.py file. I went around this error be commenting the global variable there.
second: I tried to shorten the code for checking required and optional modules in pychemqt file.
I used the same procedure that used for the optional modules for the required modules.
I modified the name of set in the tool.depences file from optional_modules to external_modules because I added to this set the data for the required modules.
I did not delete the old code and just comment it and labeled it with "not required anymore"
please let me know if you need further details.