Add local LLM support via OpenAI-compatible endpoints#2
Open
patrickvossler18 wants to merge 2 commits intomainfrom
Open
Add local LLM support via OpenAI-compatible endpoints#2patrickvossler18 wants to merge 2 commits intomainfrom
patrickvossler18 wants to merge 2 commits intomainfrom
Conversation
Wire base_url, local_model_name, and timeout params through LLMConfig, KeyphraseConfig, and all CLI scripts to LLMApi. This enables using local models served by vLLM, LM Studio, or any OpenAI-compatible server for concept generation, extraction, and keyphrase extraction steps.
The ModelConfig dataclass defaulted final_model_type to "l1", which is not a valid penalty value for train_LR (only None, "l1_sklearn", "l2" are handled). This caused an UnboundLocalError when users instantiated ModelConfig without explicitly setting final_model_type. The from_args factory already used the correct "l1_sklearn" default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire base_url, local_model_name, and timeout params through LLMConfig, KeyphraseConfig, and all CLI scripts to LLMApi. This enables using local models served by OpenAI-compatible server for concept generation, extraction, and keyphrase extraction steps.