Skip to content

shutdown outside of the handler #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

shutdown outside of the handler #41

wants to merge 1 commit into from

Conversation

jjb
Copy link
Owner

@jjb jjb commented Jan 14, 2024

because, i think but haven't totally verified, rufus will create
mutexts sometimes which is not allowed in a signal handler

because, i think but haven't totally verified, rufus will create
mutexts sometimes which is not allowed in a signal handler
@jjb
Copy link
Owner Author

jjb commented Jan 14, 2024

/cc @jmettraux

@jmettraux
Copy link

I have never heard that the creation of mutex instances is not allowed in signal handlers.

@jjb
Copy link
Owner Author

jjb commented Jan 15, 2024

@jmettraux
Copy link

jmettraux commented Jan 15, 2024

"unsafe" != "not allowed".

And the creation of mutexes in rufus-scheduler happens in rufus-scheduler instantiation mostly. I do not think you are instantating rufus-scheduler in a signal handler.

If you are afraid of the contraption becoming unsafe and want a way to bypass any Mutex#synchronize in rufus-scheduler, I'd be happy to help, but please tell me where exactly you need that in an issue.

@jjb
Copy link
Owner Author

jjb commented Jan 15, 2024

Thanks for your thoughts @jmettraux - sorry for confusion, I don't think anything needs to be changed in rufus, I just thought you might think this is sort of interesting 😄 and maybe if you had ideas for what calls in rufus might be the problem (or if you are sure it's not). I think the main culprit is, could schedule.shutdown create a mutex lock or mutex synchronize, or invoke a ruby logger (which uses mutex).

@jmettraux
Copy link

If my code is the culprit, I'd gladly accept an issue report.

@jjb
Copy link
Owner Author

jjb commented Jan 15, 2024

Thanks! but even if it is, i don't think it would be rufus' responsibility to change - was just looping you in in case you had some insights on rufus behavior. all good, hope you're well 😄

@jmettraux
Copy link

All good, very busy. I wish you a Happy New Year!

@jjb jjb closed this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants