Update gix to 0.72.1, and adapt to its breaking changes.
#6699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyagr
force-pushed
the
ig/gixupdate
branch
2 times, most recently
from
754b053 to
4636de8
Compare
This is in preparation for updating `gix` in the following commit, which changes the `gix::actor::SignatureRef` API significantly and in a way that would be awkward for this function to support.
Update `gix` to 0.72.1, and adapt to its breaking changes. 1. The signature of `gix::reference::iter::Platform::prefixed` changed in a way that seems to confuse Rust compiler (and does confuse me). 2. `git_object::Tree::EntryMode` API changed; `entry.mode()` now has a `value()` method. 3. Most significantly, the meaning and API of `gix::actor::SignatureRef` changed. ## Details about `gix::actor::SignatureRef` The API for `gix::actor::Signature` and `gix::actor::SignatureRef` changedd. The latter now contains an unparsed string time field, while the former still contains a parsed time. So, the conversions between `gix::actor::SignatureRef` and either `gix::actor::Signature` or jj's `Signature` types can now fail. We use the epoch for the time if the timestamp is unreadable, like gix did before. Cc: GitoxideLabs/gitoxide#1935, GitoxideLabs/gitoxide#2038
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(See commit descriptions)
Cc: GitoxideLabs/gitoxide#1935,
GitoxideLabs/gitoxide#2038
Checklist
If applicable:
CHANGELOG.mdREADME.md,docs/,demos/)cli/src/config-schema.json)