prefer []*RtpHeaderExtension

jiyeyuran · Oct 19, 2020 · f7d8c0a · f7d8c0a
1 parent 0427da5
commit f7d8c0a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/ortc.go b/ortc.go
@@ -110,7 +110,7 @@ func validateRtcpFeedback(fb RtcpFeedback) error {
  * Validates RtpHeaderExtension. It may modify given data by adding missing
  * fields with default values.
  */
-func validateRtpHeaderExtension(ext RtpHeaderExtension) (err error) {
+func validateRtpHeaderExtension(ext *RtpHeaderExtension) (err error) {
 	if len(ext.Kind) > 0 && ext.Kind != MediaKind_Audio && ext.Kind != MediaKind_Video {
 		return NewTypeError("invalid ext.kind")
 	}

diff --git a/rtp_parameters.go b/rtp_parameters.go
@@ -19,7 +19,7 @@ type RtpCapabilities struct {
 	/**
 	 * Supported RTP header extensions.
 	 */
-	HeaderExtensions []RtpHeaderExtension `json:"headerExtensions,omitempty"`
+	HeaderExtensions []*RtpHeaderExtension `json:"headerExtensions,omitempty"`
 
 	/**
 	 * Supported FEC mechanisms.

diff --git a/supported_rtp_capabilities.go b/supported_rtp_capabilities.go
@@ -234,7 +234,7 @@ var supportedRtpCapabilities = RtpCapabilities{
 			},
 		},
 	},
-	HeaderExtensions: []RtpHeaderExtension{
+	HeaderExtensions: []*RtpHeaderExtension{
 		{
 			Kind:             "audio",
 			Uri:              "urn:ietf:params:rtp-hdrext:sdes:mid",