Skip to content

Commit

Permalink
prefer pointer for RtpCodecSpecificParameters
Browse files Browse the repository at this point in the history
jiyeyuran committed Oct 19, 2020
1 parent e2fa96d commit 6506e6d
Showing 3 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion ortc.go
Original file line number Diff line number Diff line change
@@ -379,7 +379,7 @@ func generateRouterRtpCapabilities(mediaCodecs []RtpCodecCapability) (caps RtpCa
MimeType: fmt.Sprintf("%s/rtx", codec.Kind),
PreferredPayloadType: pt,
ClockRate: codec.ClockRate,
Parameters: RtpCodecSpecificParameters{
Parameters: &RtpCodecSpecificParameters{
Apt: codec.PreferredPayloadType,
},
RtcpFeedback: []RtcpFeedback{},
4 changes: 2 additions & 2 deletions rtp_parameters.go
Original file line number Diff line number Diff line change
@@ -86,7 +86,7 @@ type RtpCodecCapability struct {
* and 'profile-level-id' in H264 or 'profile-id' in VP9) are critical for
* codec matching.
*/
Parameters RtpCodecSpecificParameters `json:"parameters,omitempty"`
Parameters *RtpCodecSpecificParameters `json:"parameters,omitempty"`

/**
* Transport layer and codec-specific feedback messages for this codec.
@@ -242,7 +242,7 @@ type RtpCodecParameters struct {
* as 'packetization-mode' and 'profile-level-id' in H264 or 'profile-id' in
* VP9) are critical for codec matching.
*/
Parameters RtpCodecSpecificParameters `json:"parameters,omitempty"`
Parameters *RtpCodecSpecificParameters `json:"parameters,omitempty"`

/**
* Transport layer and codec-specific feedback messages for this codec.
8 changes: 4 additions & 4 deletions supported_rtp_capabilities.go
Original file line number Diff line number Diff line change
@@ -165,7 +165,7 @@ var supportedRtpCapabilities = RtpCapabilities{
Kind: "video",
MimeType: "video/H264",
ClockRate: 90000,
Parameters: RtpCodecSpecificParameters{
Parameters: &RtpCodecSpecificParameters{
RtpParameter: h264.RtpParameter{
PacketizationMode: 1,
LevelAsymmetryAllowed: 1,
@@ -183,7 +183,7 @@ var supportedRtpCapabilities = RtpCapabilities{
Kind: "video",
MimeType: "video/H264",
ClockRate: 90000,
Parameters: RtpCodecSpecificParameters{
Parameters: &RtpCodecSpecificParameters{
RtpParameter: h264.RtpParameter{
PacketizationMode: 0,
LevelAsymmetryAllowed: 1,
@@ -201,7 +201,7 @@ var supportedRtpCapabilities = RtpCapabilities{
Kind: "video",
MimeType: "video/H265",
ClockRate: 90000,
Parameters: RtpCodecSpecificParameters{
Parameters: &RtpCodecSpecificParameters{
RtpParameter: h264.RtpParameter{
PacketizationMode: 1,
LevelAsymmetryAllowed: 1,
@@ -219,7 +219,7 @@ var supportedRtpCapabilities = RtpCapabilities{
Kind: "video",
MimeType: "video/H265",
ClockRate: 90000,
Parameters: RtpCodecSpecificParameters{
Parameters: &RtpCodecSpecificParameters{
RtpParameter: h264.RtpParameter{
PacketizationMode: 0,
LevelAsymmetryAllowed: 1,

0 comments on commit 6506e6d

Please sign in to comment.