Skip to content

Use interfaceConfig.TOOLBAR_BUTTONS to hide inviteMoreHeader #7021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jun 16, 2020
Merged

Use interfaceConfig.TOOLBAR_BUTTONS to hide inviteMoreHeader #7021

merged 15 commits into from
Jun 16, 2020

Conversation

adamthewan
Copy link
Contributor

No description provided.

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@adamthewan adamthewan mentioned this pull request Jun 12, 2020
Closed
@adamthewan
Copy link
Contributor Author

I have signed the CLA

@saghul
Copy link
Member

saghul commented Jun 12, 2020

Jenkins please test this please.

saghul
saghul requested changes Jun 12, 2020
View reviewed changes
Copy link
Member

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need the logic reversed.

@damencho damencho mentioned this pull request Jun 13, 2020
Closed
@capcom-r
Copy link

Would love to see this go through soon!

@adamthewan
Copy link
Contributor Author

adamthewan commented Jun 16, 2020 •
edited
Loading

@saghul I have made the requested changes and changed "SHOW_INVITE_MORE_HEADER" to "HIDE_INVITE_MORE_HEADER"

@adamthewan adamthewan requested a review from saghul June 16, 2020 05:22
saghul
saghul reviewed Jun 16, 2020
View reviewed changes
saghul
saghul reviewed Jun 16, 2020
View reviewed changes
saghul
saghul reviewed Jun 16, 2020
View reviewed changes
saghul
saghul reviewed Jun 16, 2020
View reviewed changes
saghul
saghul reviewed Jun 16, 2020
View reviewed changes
@saghul
Copy link
Member

saghul commented Jun 16, 2020

Jenkins please test this please.

saghul
saghul approved these changes Jun 16, 2020
View reviewed changes
Copy link
Member

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some changes, LGTM now.

@saghul saghul merged commit e3d66db into jitsi:master Jun 16, 2020
@martinbaciga
Copy link

Hey guys, is this working now? I see the change in interface_config.js but when I create the call is still showing the prompt. I'm using https://meet.jit.si/external_api.js.

@damencho
Copy link
Member

This had been merged and is still not deployed on meet.jit.si. Not sure when it will get there, but I suppose it will be soon.

@adamthewan adamthewan deleted the hide-invite-more-when-alone-if-TOOLBAR_BUTTONS-no-invite branch June 17, 2020 07:56
@OrestTa
Copy link

OrestTa commented Jun 17, 2020

Seems like it's deployed on meet.jit.si now, thanks so much, everyone! :)

@martinbaciga
Copy link

Nice! Thank you so much :)

@mariobehling mariobehling mentioned this pull request Sep 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saghul saghul saghul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@adamthewan @jitsi-jenkins @saghul @capcom-r @martinbaciga @damencho @OrestTa