Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UI for local connectivity issues #5016

Merged
merged 2 commits into from
Feb 4, 2020

Conversation

paweldomas
Copy link
Member

No description provided.

@paweldomas paweldomas force-pushed the remove-local-connectivity-issues branch from 7386913 to 059426a Compare January 27, 2020 21:34
saghul
saghul previously approved these changes Jan 28, 2020
Copy link
Member

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but a sentence or two in the commit message with the reasoning would be ideal.

Removes the blur effect from the large video and stops showing
the network connectivity issues message when ICE disconnects.

The feature has been considered too disruptive and there's a plan to
have it replaced with a more subtle indication.
@saghul saghul merged commit 97e8a6c into master Feb 4, 2020
@paweldomas paweldomas deleted the remove-local-connectivity-issues branch February 4, 2020 15:11
@luixxiul luixxiul added android Issue related to the Android operating system ui/ux User Interface / User Experience related issues and removed android Issue related to the Android operating system labels May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux User Interface / User Experience related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants