Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(Filmstrip): Optimize resizes. #4992

Merged
merged 4 commits into from
Jan 24, 2020
Merged

ref(Filmstrip): Optimize resizes. #4992

merged 4 commits into from
Jan 24, 2020

Conversation

hristoterezov
Copy link
Member

No description provided.

virtuacoplenny
virtuacoplenny suggested changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@virtuacoplenny virtuacoplenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were a few bugs that need fixing. I also noticed in vertical filmstrip on hover over thumbnails that the video image isn't getting the darker overlay, which is used to make the display name easier to read.

css/_videolayout_default.scss Outdated Show resolved Hide resolved
modules/UI/videolayout/LocalVideo.js Outdated Show resolved Hide resolved
css/filmstrip/_small_video.scss Show resolved Hide resolved
css/filmstrip/_vertical_filmstrip.scss Show resolved Hide resolved
css/filmstrip/_vertical_filmstrip.scss Show resolved Hide resolved
modules/UI/videolayout/RemoteVideo.js Outdated Show resolved Hide resolved
react/features/base/conference/middleware.js Show resolved Hide resolved
react/features/filmstrip/components/web/AudioMutedIndicator.js Show resolved Hide resolved
react/features/filmstrip/components/web/Filmstrip.js Outdated Show resolved Hide resolved
react/features/filmstrip/subscriber.web.js Show resolved Hide resolved
@hristoterezov
Copy link
Member Author

@virtuacoplenny All reported bugs should be fixed.

virtuacoplenny
virtuacoplenny previously approved these changes Jan 23, 2020
View reviewed changes
@hristoterezov hristoterezov merged commit 31d9fb1 into master Jan 24, 2020
@hristoterezov hristoterezov deleted the ref-thumbail-resize branch January 24, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@virtuacoplenny virtuacoplenny virtuacoplenny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hristoterezov @virtuacoplenny