fix(filmstrip) Add handlers for track streaming status on RN. #11584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for switching between video and avatar when the track's streaming status changes in source-name signaling mode.
jallamsetty1
force-pushed
the
fix-rn-trackStreamingStatus
branch
from
05c0039 to
a4285f3
Compare
paweldomas
reviewed
May 25, 2022
| /* Then check if the participant connection is active. */ | ||
| const connectionStatus = participant.connectionStatus || JitsiParticipantConnectionStatus.ACTIVE; | ||
| /* Then check if the participant connection or track streaming status is active. */ | ||
| if (getSourceNameSignalingFeatureFlag(state)) { |
There was a problem hiding this comment.
It's worth leaving a TODO/comment that this code will only work if there's something else registered as a listener of this specific jitsiTracks streaming status (it's disabled when there's 0 listeners).
Rendering the virtual screenshare on RN has been implemented already. |
paweldomas
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for switching between video and avatar when the track's streaming status changes in source-name signaling mode.