Fixes for highlights mobile #11209
Merged
Fixes for highlights mobile #11209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabiborlea
changed the title
gabiborlea
changed the title
saghul
approved these changes
Mar 24, 2022
|
@saghul added some screenshots |
|
Buttons should be stacked vertically, that's the common mobile UX pattern. |
saghul
requested changes
Mar 24, 2022
horymury
reviewed
Mar 25, 2022
| flex: 1, | ||
| flexDirection: 'row', | ||
| justifyContent: 'center', | ||
| alignItems: 'center' |
There was a problem hiding this comment.
think you could replace:
flexDirection: 'row', justifyContent: 'center', alignItems: 'center'
with : justifyContent: 'space-around'
gabiborlea
force-pushed
the
gborlea/fix-highlight-mobile
branch
from
060e845 to
303359b
Compare
gabiborlea
changed the title
gabiborlea
force-pushed
the
gborlea/fix-highlight-mobile
branch
from
d575abd to
c5a3a4b
Compare
fix(highlights): switch buttons order fix(highlights): remove unused logger import
gabiborlea
force-pushed
the
gborlea/fix-highlight-mobile
branch
from
c5a3a4b to
73935d8
Compare
saghul
previously approved these changes
Apr 1, 2022
gabiborlea
commented
Apr 1, 2022
| @@ -215,7 +215,7 @@ export async function sendMeetingHighlight(state: Object) { | |||
|
|
|||
| const reqBody = { | |||
| meetingFqn: extractFqnFromPath(state), | |||
| sessionId: conference.sessionId, | |||
| sessionId: conference.sessionId || conference.room.meetingId, | |||
There was a problem hiding this comment.
@saghul is this a good way to get the sessionId on mobile?
There was a problem hiding this comment.
Suggested change
| sessionId: conference.sessionId || conference.room.meetingId, | |
| sessionId: conference.getMeetingUniqueId(), |
saghul
approved these changes
Apr 1, 2022
tmoldovan8x8
pushed a commit
that referenced
this pull request
Apr 5, 2022
This was referenced Apr 5, 2022
Closed
Closed
Merged
ankit-programmer
pushed a commit
to ankit-programmer/jitsi-meet
that referenced
this pull request
May 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use stacked buttons
Before
After
Fix get sessionId on mobile