refactor(virtual-background): use jss instead of sass #11152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for your contribution! |
robertpin
suggested changes
Mar 22, 2022
react/features/virtual-background/components/UploadImageButton.js
Outdated
Show resolved
Hide resolved
react/features/virtual-background/components/VirtualBackgroundPreview.js
Outdated
Show resolved
Hide resolved
react/features/virtual-background/components/VirtualBackgroundPreview.js
Outdated
Show resolved
Hide resolved
react/features/virtual-background/components/VirtualBackgroundDialog.js
Outdated
Show resolved
Hide resolved
react/features/virtual-background/components/VirtualBackgroundDialog.js
Outdated
Show resolved
Hide resolved
react/features/virtual-background/components/UploadImageButton.js
Outdated
Show resolved
Hide resolved
|
@c0m1t I don't see any changes. Forgot to push? |
c0m1t
force-pushed
the
virtual-background-jss
branch
from
56ff702 to
9ea3559
Compare
|
@robertpin Oh, I pushed it. |
robertpin
approved these changes
Mar 29, 2022
jallamsetty1
pushed a commit
that referenced
this pull request
Mar 30, 2022
jallamsetty1
pushed a commit
that referenced
this pull request
Mar 30, 2022
jallamsetty1
pushed a commit
to jallamsetty1/jitsi-meet
that referenced
this pull request
Mar 30, 2022
This was referenced Apr 5, 2022
Closed
Closed
Merged
ankit-programmer
pushed a commit
to ankit-programmer/jitsi-meet
that referenced
this pull request
May 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert Sass to JSS in
virtual-backgroundfeature.