Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(external-api): expose config for breakout rooms #11055

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

mihhu
Copy link
Member

@mihhu mihhu commented Mar 1, 2022

Add hideJoinRoomButton and move hideAddRoomButton under the common key (backwards compatibility included).

Copy link
Member

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, PTAL.

@mihhu mihhu force-pushed the join-moderator-only branch 3 times, most recently from 63ed78e to e778627 Compare March 2, 2022 09:20
@mihhu mihhu requested a review from saghul March 2, 2022 09:30
Copy link
Member

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor nit, LGTM otherwise, nice work!

@mihhu mihhu force-pushed the join-moderator-only branch from e778627 to 22466d4 Compare March 2, 2022 09:40
@mihhu mihhu changed the title feat(external-api): expose config to limit join breakout room functionality to moderators feat(external-api): expose config for breakout rooms Mar 2, 2022
@mihhu mihhu requested a review from saghul March 2, 2022 09:50
@mihhu mihhu merged commit 936d9b4 into jitsi:master Mar 2, 2022
ankit-programmer pushed a commit to ankit-programmer/jitsi-meet that referenced this pull request May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants