fix(lobby-notifications): Prevent lobby notification to remain on scr… #11054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
requested changes
Mar 1, 2022
react/features/lobby/middleware.js
Outdated
| dispatch(rejectKnockingParticipant(firstParticipant.id)); | ||
| }) ]; | ||
| } | ||
| if (knockingParticipants.length === 0) { |
There was a problem hiding this comment.
Can you please move this up? Otherwise the code will first create a notification that will never be used. We can check this the first thing and return early.
react/features/lobby/middleware.js
Outdated
| let icon; | ||
|
|
||
| const knockingParticipants = getKnockingParticipants(getState()); | ||
| const firstParticipant = knockingParticipants[0]; |
There was a problem hiding this comment.
Move this constant to the branch where its actually used please.
react/features/lobby/middleware.js
Outdated
| dispatch(hideNotification(LOBBY_NOTIFICATION_ID)); | ||
| dispatch(openParticipantsPane()); | ||
| }) ]; | ||
| } else { |
There was a problem hiding this comment.
While we are here, please let's reverse the logic. Check if length === 1, and do the other part in the else.
saghul
requested changes
Mar 1, 2022
react/features/lobby/middleware.js
Outdated
| dispatch(hideNotification(LOBBY_NOTIFICATION_ID)); | ||
| dispatch(rejectKnockingParticipant(firstParticipant.id)); | ||
| }) ]; | ||
| } else if (knockingParticipants.length > 1) { |
|
|
||
| if (knockingParticipants.length === 0) { | ||
| dispatch(hideNotification(LOBBY_NOTIFICATION_ID)); | ||
| } else { |
There was a problem hiding this comment.
You could just return in the if branch, to avoid a large else.
| customActionHandler, | ||
| icon | ||
| }, NOTIFICATION_TIMEOUT_TYPE.STICKY)); | ||
| _handleLobbyNotification({ |
There was a problem hiding this comment.
nit: leave a newline for for extra breathing room :-)
saghul
approved these changes
Mar 1, 2022
|
Perfect! |
Merged
This was referenced Apr 5, 2022
Closed
Closed
Merged
ankit-programmer
pushed a commit
to ankit-programmer/jitsi-meet
that referenced
this pull request
May 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…een.