feat(filmstrip/toolbox) mobile ui updates #11051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
reviewed
Mar 1, 2022
| @@ -364,7 +364,10 @@ class Conference extends AbstractConference<Props, State> { | |||
|
|
|||
| <LonelyMeetingExperience /> | |||
|
|
|||
| { _shouldDisplayTileView || <><Filmstrip /><Toolbox /></> } | |||
| { _shouldDisplayTileView || <> | |||
| <Filmstrip _toolboxVisible = { _toolboxVisible } /> | |||
There was a problem hiding this comment.
Can you pl remove the explicit prop and make it internal to the filmstrip?
saghul
reviewed
Mar 1, 2022
| @@ -59,6 +61,7 @@ function Toolbox(props: Props) { | |||
| } | |||
|
|
|||
| const { _styles, _width, _reactionsEnabled } = props; | |||
| const bottomEdge = Platform.OS === 'ios' && props._visible; | |||
saghul
reviewed
Mar 1, 2022
| justifyContent: 'space-between', | ||
| margin: BaseTheme.spacing[2] | ||
| paddingLeft: BaseTheme.spacing[2], |
There was a problem hiding this comment.
You can simplify this with paddingHorizontal
There was a problem hiding this comment.
This is removed.
saghul
reviewed
Mar 1, 2022
| @@ -45,7 +45,8 @@ export default { | |||
| flexDirection: 'row', | |||
| flexGrow: 0, | |||
| justifyContent: 'flex-end', | |||
| marginBottom: BaseTheme.spacing[1] | |||
| marginHorizontal: 6, | |||
Calinteodor
added a commit
that referenced
this pull request
Mar 1, 2022
Merged
This was referenced Apr 5, 2022
Closed
Closed
Merged
ankit-programmer
pushed a commit
to ankit-programmer/jitsi-meet
that referenced
this pull request
May 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.