Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filmstrip) Fix resizable filmstrip #11025

Merged
merged 1 commit into from
Mar 2, 2022
Merged

fix(filmstrip) Fix resizable filmstrip #11025

merged 1 commit into from
Mar 2, 2022

Conversation

robertpin
Copy link
Contributor

@robertpin robertpin commented Feb 25, 2022

Re-calculate tile sizes after config loaded
Make local tile always respect the ratio in interface_config
Merge calculate size for vertical view functions into one function

@saghul saghul requested a review from hristoterezov February 25, 2022 10:21
saghul
saghul previously approved these changes Feb 25, 2022
Copy link
Member

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a suggestion. I'd also like @hristoterezov to take a look.

saghul
saghul previously approved these changes Feb 28, 2022
Copy link
Member

@hristoterezov hristoterezov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a question

Re-calculate tile sizes after config loaded
Make local tile always respect the ratio in interface_config
Merge calculate size for vertical view functions into one function
@robertpin robertpin merged commit 8bb5c11 into jitsi:master Mar 2, 2022
@robertpin robertpin deleted the rpintilii/resizable-filmstrip-fix branch March 2, 2022 14:46
ankit-programmer pushed a commit to ankit-programmer/jitsi-meet that referenced this pull request May 7, 2022
Re-calculate tile sizes after config loaded
Make local tile always respect the ratio in interface_config
Merge calculate size for vertical view functions into one function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants