Passing the url to conference mapper #11013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damencho
force-pushed
the
confmapper-pass-url
branch
from
f2b4c54 to
6251d71
Compare
| import { DialInSummary } from '../dial-in-summary'; | ||
|
|
||
| import NoRoomError from './NoRoomError'; | ||
|
|
||
| document.addEventListener('DOMContentLoaded', () => { | ||
| const { room } = parseURLParams(window.location, true, 'search'); | ||
| const { href } = window.location; | ||
| const ix = href.indexOf(DIAL_IN_INFO_PAGE_PATH_NAME); | ||
| const url = (ix > 0 ? href.substring(0, ix) : href) + room; |
There was a problem hiding this comment.
Do we want to get the host and protocol part only with the whole substring logic or we have an use case where we take part of the path as well?
If we want only the host and protocol maybe it will be easier:
const { host, protocol } = location;
// and then it will be:
`${protocol}://${host}/`
react/features/invite/functions.js
Outdated
| @@ -533,7 +534,7 @@ export function getShareInfoText( | |||
|
|
|||
| numbersPromise = Promise.all([ | |||
| getDialInNumbers(dialInNumbersUrl, room, mucURL), | |||
| getDialInConferenceID(dialInConfCodeUrl, room, mucURL) | |||
| getDialInConferenceID(dialInConfCodeUrl, room, mucURL, locationURL.href) | |||
There was a problem hiding this comment.
We'll be passing the whole URL with the params and everything this way. Is this OK? Do we need the whole URL?
damencho
force-pushed
the
confmapper-pass-url
branch
from
d8f1abe to
d0b1423
Compare
damencho
force-pushed
the
confmapper-pass-url
branch
from
d0b1423 to
dbfb6dd
Compare
hristoterezov
approved these changes
Feb 28, 2022
This was referenced Mar 1, 2022
Merged
Merged
This was referenced Apr 5, 2022
Closed
Closed
Merged
ankit-programmer
pushed a commit
to ankit-programmer/jitsi-meet
that referenced
this pull request
May 7, 2022
* fix: Moves getDialInConferenceID, so we can reuse conf mapper url generation. * fix: Moves getDialInNumbers, so we can reuse url generation. * squash: Moves dialInInfo page path to constants. * feat: Adds the location address as a param to the conf mapper request. * feat: Adds option conf mapper and numbers urls to contain parameters (?). * squash: Adds more doc comments. * squash: Makes sure we strip url params if any, and they do not reach fetch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.