Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(multi-stream-support) Support track streaming status #10934

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

WillLiang918
Copy link
Contributor

@WillLiang918 WillLiang918 commented Feb 9, 2022

Start listening to the TRACK_STREAMING_STATUS_CHANGED event introduced in jitsi/lib-jitsi-meet#1855. This implementation still assumes only one video track per participant.

High level objectives:

  • Handle the init and dispose logic for TrackStreamingStatus when a connection icon is rendered. This is an optimization to help the performance in large conferences.
  • Replace the participant connection status logic with track streaming status throughout the code base. Ensure backwards compatibility when the feature flag is disabled and feature parity when enabled.
  • Add streamingStatus property to the Track data model in the redux store and add code to update this new property.

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@jallamsetty1
Copy link
Member

Jenkins add to whitelist.

@WillLiang918 WillLiang918 force-pushed the track-streaming-status branch 2 times, most recently from 7bb5920 to bc2aca5 Compare February 17, 2022 16:43
@WillLiang918 WillLiang918 force-pushed the track-streaming-status branch from bc2aca5 to dd895c4 Compare February 17, 2022 18:35
@WillLiang918 WillLiang918 marked this pull request as ready for review February 17, 2022 18:40
Copy link
Member

@paweldomas paweldomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the code looks good. There's one problem that we don't have to solve right now, which is that whether or not things will work depends if the connection indicator is in the UI for some non reactified code (large video?). The connection indicator is the one that's writing track streaming status to redux. Eventually, the goal should be to reactify the large video, so that it uses a hook and checks for the status locally.

@paweldomas
Copy link
Member

I will approve after testing.

@paweldomas paweldomas merged commit 05dc018 into jitsi:master Feb 23, 2022
@WillLiang918 WillLiang918 deleted the track-streaming-status branch March 14, 2022 14:40
ankit-programmer pushed a commit to ankit-programmer/jitsi-meet that referenced this pull request May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants