-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(multi-stream-support) Support track streaming status #10934
Conversation
Hi, thanks for your contribution! |
react/features/connection-indicator/components/web/ConnectionIndicator.js
Outdated
Show resolved
Hide resolved
Jenkins add to whitelist. |
7bb5920
to
bc2aca5
Compare
…c with track streaming status
bc2aca5
to
dd895c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the code looks good. There's one problem that we don't have to solve right now, which is that whether or not things will work depends if the connection indicator is in the UI for some non reactified code (large video?). The connection indicator is the one that's writing track streaming status to redux. Eventually, the goal should be to reactify the large video, so that it uses a hook and checks for the status locally.
I will approve after testing. |
…c with track streaming status (jitsi#10934)
Start listening to the
TRACK_STREAMING_STATUS_CHANGED
event introduced in jitsi/lib-jitsi-meet#1855. This implementation still assumes only one video track per participant.High level objectives:
init
anddispose
logic forTrackStreamingStatus
when a connection icon is rendered. This is an optimization to help the performance in large conferences.streamingStatus
property to the Track data model in the redux store and add code to update this new property.