feat(tileView): Display 3 participants in 1 row #10860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damencho
previously approved these changes
Jan 26, 2022
|
The failure is due to the changes, the remote menu is not visible or something. |
saghul
reviewed
Jan 27, 2022
| const columnsToMaintainASquare = Math.ceil(Math.sqrt(numberOfParticipants)); | ||
| // When there are 3 participants in the call we want them to be placed on a single row unless the maxColumn setting | ||
| // is lower. | ||
| const columnsToMaintainASquare = numberOfParticipants === 3 ? 3 : Math.ceil(Math.sqrt(numberOfParticipants)); |
There was a problem hiding this comment.
Nit: can we make that number 3 a constant?
There was a problem hiding this comment.
This is mostly an exception. What would be the benefit of having constant?
hristoterezov
force-pushed
the
3-participant-in-row
branch
from
4d49165 to
1a14775
Compare
|
IIRC we didn't just want to show 3 people on one row, but even more, depending on the size of the client. |
Workaround for the issue when the mouse enter event is not triggered in the use case where the layout changes and the mouse appears onn top of the thumbnail. Example: Closing the participant pane.
@robertpin Good idea! I will discuss it with Emil! But lets leave it for version 2. |
damencho
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.