Skip to content

Commit

Permalink
Removes Firefox extension handle (removed in FF newer than latest ESR).
Browse files Browse the repository at this point in the history
  • Loading branch information
damencho authored and bgrozev committed Mar 21, 2018
1 parent 823481d commit a902540
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 32 deletions.
6 changes: 0 additions & 6 deletions conference.js
Original file line number Diff line number Diff line change
Expand Up @@ -1709,12 +1709,6 @@ export default {
}
);

return;
} else if (error.name === JitsiTrackErrors.FIREFOX_EXTENSION_NEEDED) {
APP.UI.showExtensionRequiredDialog(
config.desktopSharingFirefoxExtensionURL
);

return;
}

Expand Down
14 changes: 0 additions & 14 deletions config.js
Original file line number Diff line number Diff line change
Expand Up @@ -150,23 +150,9 @@ var config = {
// Required version of Chrome extension
desktopSharingChromeMinExtVersion: '0.1',

// The ID of the jidesha extension for Firefox. If null, we assume that no
// extension is required.
desktopSharingFirefoxExtId: null,

// Whether desktop sharing should be disabled on Firefox.
desktopSharingFirefoxDisabled: false,

// The maximum version of Firefox which requires a jidesha extension.
// Example: if set to 41, we will require the extension for Firefox versions
// up to and including 41. On Firefox 42 and higher, we will run without the
// extension.
// If set to -1, an extension will be required for all versions of Firefox.
desktopSharingFirefoxMaxVersionExtRequired: 51,

// The URL to the Firefox extension for desktop sharing.
desktopSharingFirefoxExtensionURL: null,

// Optional desktop sharing frame rate options. Default value: min:5, max:5.
// desktopSharingFrameRate: {
// min: 5,
Expand Down
2 changes: 0 additions & 2 deletions lang/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -278,8 +278,6 @@
"tokenAuthFailed": "Sorry, you're not allowed to join this call.",
"displayNameRequired": "Display name is required",
"enterDisplayName": "Please enter your display name",
"extensionRequired": "Extension required:",
"firefoxExtensionPrompt": "You need to install a Firefox extension in order to use screen sharing. Please try again after you <a href='__url__'>get it from here</a>!",
"feedbackHelp": "Your feedback will help us to improve our video experience.",
"feedbackQuestion": "Tell us about your call!",
"thankYou": "Thank you for using __appName__!",
Expand Down
10 changes: 0 additions & 10 deletions modules/UI/UI.js
Original file line number Diff line number Diff line change
Expand Up @@ -1039,16 +1039,6 @@ UI.getLargeVideo = function() {
*/
UI.isPinned = userId => VideoLayout.getPinnedId() === userId;

/**
* Shows dialog with a link to FF extension.
*/
UI.showExtensionRequiredDialog = function(url) {
messageHandler.openMessageDialog(
'dialog.extensionRequired',
'[html]dialog.firefoxExtensionPrompt',
{ url });
};

/**
* Shows "Please go to chrome webstore to install the desktop sharing extension"
* 2 button dialog with buttons - cancel and go to web store.
Expand Down

0 comments on commit a902540

Please sign in to comment.