Do not assume remote video menu dom structure and change to click #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbaldino
reviewed
Jul 19, 2017
| @@ -159,29 +159,25 @@ public void ownerMutesParticipantAndCheck() | |||
|
|
|||
| WebElement elem = owner.findElement(By.xpath( | |||
| TestUtils.getXPathStringForClassName("//span", "remotevideomenu") | |||
| + "/i[@class='icon-thumb-menu']")); | |||
| + "//i[@class='icon-thumb-menu']")); | |||
There was a problem hiding this comment.
is it worth having constants for these selectors?
There was a problem hiding this comment.
Yes, it's worthwhile but almost all these files have these selectors inlined. What needs to happen, and what I'd really like to do this year, is start moving these over into page objects to encapsulate these lookups, moving these to constants in the process.
There was a problem hiding this comment.
(In other words, I agree but not sure I should do it at this point for consistency.)
There was a problem hiding this comment.
But then again why not? It is better for readability. I'll just make the change now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.