-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A/V moderation #734
A/V moderation #734
Conversation
Codecov Report
@@ Coverage Diff @@
## master #734 +/- ##
============================================
- Coverage 47.20% 46.71% -0.49%
- Complexity 881 882 +1
============================================
Files 113 115 +2
Lines 6500 6627 +127
Branches 914 935 +21
============================================
+ Hits 3068 3096 +28
- Misses 3037 3121 +84
- Partials 395 410 +15
Continue to review full report at Codecov.
|
I think that all comments across the PRs are fixed, but I realized there is one flow missing in the logic ... but I think we need to discuss it, I have a simple resolution of it, but we need to take care of the concurrency ... so let's discuss it offline on Monday. |
Force mutes participants that joined later in the meeting which was av moderated.
logger.warn("Unmute not allowed, muterJid=" + muterJid + ", toBeMutedJid=" + toBeMutedJid); | ||
return MuteResult.NOT_ALLOWED; | ||
} | ||
else if (this.chatRoom.isAvModerationEnabled(mediaType)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This first check is redundant, since isMemberAllowedToUnmute
performs it.
No description provided.