-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avoid xmlstring builder toString #1118
avoid xmlstring builder toString #1118
Conversation
bgrozev
commented
Oct 26, 2023
- chore: Update jitsi-xmpp-extensions.
- log: Remove System.err logs.
- fix: Avoid using XmlStringBuilder.toString.
Codecov Report
@@ Coverage Diff @@
## master #1118 +/- ##
============================================
- Coverage 27.88% 27.86% -0.02%
Complexity 473 473
============================================
Files 128 128
Lines 7779 7783 +4
Branches 1064 1064
============================================
Hits 2169 2169
- Misses 5338 5342 +4
Partials 272 272
Continue to review full report in Codecov by Sentry.
|
} | ||
|
||
@Override | ||
public void onOutgoingStreamElement(TopLevelStreamElement streamElement) | ||
{ | ||
logger.debug(() -> "SENT PKT (" + id + "): " + streamElement.toXML()); | ||
logger.debug( | ||
() -> "SENT PKT (" + id + "): " + XmlStringBuilderUtil.Companion.toStringOpt(streamElement.toXML()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If your method in jitsi-xmpp-extensions were on Element
rather than ExtensionElement
this could just use the non-companion flavor of toStringOpt
-- is it worth it? (I think it clearly would be if this were Kotlin, but it's less obvious for Java.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed this was awkward, but I didn't think it's worth another jitsi-xmpp-extensions update