Use 503 for "soft" failures. #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bgrozev
commented
Feb 9, 2023
bgrozev
commented
- ref: Move JicofoHealthChecker to kotlin.
- feat: Adapt to jicoco changes, use "soft" failure (503 instead of 500) for MUC and ping timeouts.
…) for MUC and ping timeouts.
aaronkvanmeerten
previously approved these changes
Feb 10, 2023
| } | ||
|
|
||
| private fun performCheck() { | ||
| Objects.requireNonNull(focusManager, "FocusManager is not set.") |
There was a problem hiding this comment.
This can just be requireNonNull in Kotlin.
| check() | ||
| val duration = System.currentTimeMillis() - start | ||
| if (duration > HealthConfig.config.maxCheckDuration.toMillis()) { | ||
| logger.error("Health check took too long: " + duration + "ms") |
| if (bridgeSelector.operationalBridgeCount <= 0) { | ||
| throw RuntimeException( | ||
| "No operational bridges available (total bridge count: " | ||
| + BridgeSelector.bridgeCount.get() + ")") |
| throw RuntimeException("Failed to create conference with room name $roomName") | ||
| } | ||
| } catch (e: Exception) { | ||
| throw RuntimeException("Failed to create conference with room name " + roomName + ":" + e.message) |
|
|
||
| // Wait for 5 seconds to receive a response. | ||
| if (!pingResponseWait.await(5, TimeUnit.SECONDS)) { | ||
| throw RuntimeException("did not receive xmpp ping response for (${xmppProvider.config.name})") |
There was a problem hiding this comment.
Why is the name in parentheses?
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1044 +/- ##
============================================
- Coverage 27.42% 27.33% -0.10%
Complexity 477 477
============================================
Files 124 124
Lines 7416 7437 +21
Branches 1056 1061 +5
============================================
- Hits 2034 2033 -1
- Misses 5130 5149 +19
- Partials 252 255 +3
Continue to review full report at Codecov.
|
JonathanLennox
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.