Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add resetAll() to MetricsContainer for testing. #176

Merged
merged 2 commits into from
Aug 10, 2022

Conversation

alexcsf
Copy link
Contributor

@alexcsf alexcsf commented Aug 10, 2022

Adds a resetAll() method to MetricsContainer which resets all of its Metrics to their respective initial values.

@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #176 (fea17fb) into master (332f4e7) will increase coverage by 0.74%.
The diff coverage is 88.23%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #176      +/-   ##
============================================
+ Coverage     22.04%   22.78%   +0.74%     
- Complexity      112      122      +10     
============================================
  Files            32       32              
  Lines          1107     1119      +12     
  Branches        101      101              
============================================
+ Hits            244      255      +11     
- Misses          844      846       +2     
+ Partials         19       18       -1     
Impacted Files Coverage Δ
...main/kotlin/org/jitsi/metrics/DoubleGaugeMetric.kt 22.22% <33.33%> (-2.78%) ⬇️
...src/main/kotlin/org/jitsi/metrics/BooleanMetric.kt 92.30% <100.00%> (+8.97%) ⬆️
...src/main/kotlin/org/jitsi/metrics/CounterMetric.kt 100.00% <100.00%> (ø)
...cs/src/main/kotlin/org/jitsi/metrics/InfoMetric.kt 100.00% <100.00%> (ø)
...c/main/kotlin/org/jitsi/metrics/LongGaugeMetric.kt 100.00% <100.00%> (ø)
.../main/kotlin/org/jitsi/metrics/MetricsContainer.kt 80.48% <100.00%> (+1.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 332f4e7...fea17fb. Read the comment docs.

@bgrozev bgrozev merged commit 1e384d9 into jitsi:master Aug 10, 2022
@alexcsf alexcsf deleted the reset-metrics branch August 11, 2022 15:07
bgrozev added a commit to bgrozev/jicofo that referenced this pull request Sep 15, 2022
bgrozev added a commit to jitsi/jicofo that referenced this pull request Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants