Rename recorder domain to hidden domain #1945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
approved these changes
Oct 21, 2024
aaronkvanmeerten
approved these changes
Oct 21, 2024
…he transcriber and the recorder
M4GNV5
force-pushed
the
hidden-domain3
branch
from
58e3a35
to
bec7895
Compare
|
I rebased this PR and added the one remaining change request. I hope this makes everything ready to be merged |
saghul
approved these changes
Nov 12, 2024
|
Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is bacially the leftovers of #1737.
Since the addition of
transcriber.yamlby @aaronkvanmeerten the main functionality from the original PR already exist.This PR simply renames the "recorder" domain to a more generic "hidden" domain, since it is used not only by the recorder, but also by the transcriber.