-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update acme.sh Version to 3.0.7 #1792
Conversation
Upgrade acme.sh version to 3.0.1
Are no other changes required? |
Tested on docker version running with no issue, didn't test on renewal etc, i suppose this would be the same since the script is to run acme.sh |
Why 3.0.1 and not 3.0.7? |
Update acme.sh to 3.0.7
My intention was to update it to 3.0.7 (the latest version which was released as of today), i was testing on 3.0.1 to ensure that when i upgrade from 2.8.8 to 3.0.1 it's working fine, before proceeding to it's latest version 3.0.7 I've update the PR code to 3.0.7 |
Excellent! |
I'll give it a try before merging. |
So I tried it and it did not refresh the existing cert properly :-/ Perhaps it has something to do with switching LE engines, in version 2 Let's Encrypt was the default engine, and in version 3 it's ZeroSSL. I think we should have a parameter controlling that default. Deleting ~/.jitsi-meet-cfg/web/acme* and restarting made the setup work. Not sure this is an acceptable solution though. |
If you start a server anew, the whole docker will not load up because of the acme failure |
Not sure what you mean, can you clarify? Is that with the old or the new version? |
With the older version |
Yes, I can see that:
That doesn't negate what I said earlier though. Given this, it's probably a good idea to just update at this point and make the backend configurable at a later stage. |
Thanks @zhenguang / @saghul. This should resolve the issue I created last week. My conclusion was also that acme.sh needed to be upgraded. I'll do some testing and close out that issue once verified. |
Thank you! |
FYI - I confirmed that this resolved #1795. |
Wonderful! |
Upgrade acme.sh version to 3.0.7
Having ACME error on cert creation when using the older version, upgrade to 3.0.7 official as of 25 April 2024
3.0.7