Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update acme.sh Version to 3.0.7 #1792

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Update acme.sh Version to 3.0.7 #1792

merged 2 commits into from
Apr 29, 2024

Conversation

zhenguang
Copy link
Contributor

Upgrade acme.sh version to 3.0.7

Having ACME error on cert creation when using the older version, upgrade to 3.0.7 official as of 25 April 2024

3.0.7

Upgrade acme.sh version to 3.0.1
@zhenguang zhenguang changed the title Update acme.sh Update acme.sh Version to 3.0.7 Apr 25, 2024
@saghul
Copy link
Member

saghul commented Apr 25, 2024

Are no other changes required?

@zhenguang
Copy link
Contributor Author

Tested on docker version running with no issue, didn't test on renewal etc, i suppose this would be the same since the script is to run acme.sh

@saghul
Copy link
Member

saghul commented Apr 27, 2024

Why 3.0.1 and not 3.0.7?

Update acme.sh to 3.0.7
@zhenguang
Copy link
Contributor Author

My intention was to update it to 3.0.7 (the latest version which was released as of today), i was testing on 3.0.1 to ensure that when i upgrade from 2.8.8 to 3.0.1 it's working fine, before proceeding to it's latest version 3.0.7

I've update the PR code to 3.0.7

@saghul
Copy link
Member

saghul commented Apr 28, 2024

Excellent!

@saghul
Copy link
Member

saghul commented Apr 28, 2024

I'll give it a try before merging.

@saghul
Copy link
Member

saghul commented Apr 29, 2024

So I tried it and it did not refresh the existing cert properly :-/ Perhaps it has something to do with switching LE engines, in version 2 Let's Encrypt was the default engine, and in version 3 it's ZeroSSL.

I think we should have a parameter controlling that default.

Deleting ~/.jitsi-meet-cfg/web/acme* and restarting made the setup work. Not sure this is an acceptable solution though.

@zhenguang
Copy link
Contributor Author

If you start a server anew, the whole docker will not load up because of the acme failure

@saghul
Copy link
Member

saghul commented Apr 29, 2024

Not sure what you mean, can you clarify? Is that with the old or the new version?

@zhenguang
Copy link
Contributor Author

With the older version

@saghul
Copy link
Member

saghul commented Apr 29, 2024

Yes, I can see that:

web-1      | [Mon Apr 29 10:01:08 UTC 2024] Create account key ok.
web-1      | [Mon Apr 29 10:01:08 UTC 2024] Only RSA or EC key is supported. keyfile=/config/acme.sh/ca/acme-v02.api.letsencrypt.org/account.key
web-1      | [Mon Apr 29 10:01:08 UTC 2024] Please add '--debug' or '--log' to check more details.
web-1      | [Mon Apr 29 10:01:08 UTC 2024] See: https://github.com/acmesh-official/acme.sh/wiki/How-to-debug-acme.sh
web-1      | [Mon Apr 29 10:01:08 UTC 2024] Run post hook:'if [[ -d /var/run/s6/services/nginx ]]; then s6-svc -u /var/run/s6/services/nginx; fi'
web-1      | Failed to obtain a certificate from the Let's Encrypt CA.

That doesn't negate what I said earlier though.

Given this, it's probably a good idea to just update at this point and make the backend configurable at a later stage.

@saghul saghul merged commit fed87fb into jitsi:master Apr 29, 2024
1 check passed
@jplandry908
Copy link

Thanks @zhenguang / @saghul. This should resolve the issue I created last week. My conclusion was also that acme.sh needed to be upgraded. I'll do some testing and close out that issue once verified.

#1795

@saghul
Copy link
Member

saghul commented May 1, 2024

Thank you!

@jplandry908
Copy link

FYI - I confirmed that this resolved #1795.

@saghul
Copy link
Member

saghul commented May 1, 2024

Wonderful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants