fix(web) 🐛 wrong quote in default config #1761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HannesOberreiter
changed the title
| @@ -22,7 +22,7 @@ config.focusUserJid = 'focus@{{$XMPP_AUTH_DOMAIN}}'; | |||
|
|
|||
| {{ if $ENABLE_SUBDOMAINS -}} | |||
| var subdir = '<!--# echo var="subdir" default="" -->'; | |||
| var subdomain = "<!--# echo var="subdomain" default="" -->"; | |||
| var subdomain = '<!--# echo var="subdomain" default="" -->'; | |||
There was a problem hiding this comment.
I'm curious what impact you saw from this?
The nginx container shoudl be replacing the full contents from <!-- all the way to --> using SSI directives before any javascript is parsed by the browser. So there should not be any point at which the quotes conflict.
There was a problem hiding this comment.
Currently setting up a dev environment to make some changes on the jitsi meet server code and was struggling to load the config and though maybe its this, but just found out it was something different. So it is no bug only style and it now follows the jitsi-meet repo:
There was a problem hiding this comment.
Excellent, I'm all for consistency but I just wanted to ensure I understood the impact of the existing code.
aaronkvanmeerten
approved these changes
Mar 19, 2024
saghul
added a commit
that referenced
this pull request
Mar 22, 2024
* a5ebb99 jibri: flag to support prometheus-style metrics (#1768) * 80fc10e feat(prosody): Cleans up gc settings. * 69bba17 feat(prosody): Adjusts lua to use generational GC for brewery.cfg.lua. * 2798426 feat(prosody): Adjusts lua to use generational GC. * 28d2b32 feat(prosody): Make sure muc tumbstones is disabled. * d5df19d jigasi: autoscaler sidecar support (#1738) * 0953ca0 jigasi: skip SIP configuration when configured as a transcriber * ca1d670 fix: 🐛 wrong quote in default config (#1761) * 360361e jibri: move xmpp config for easier override (#1748) * 452f5ba misc: working on unstable
benbz
added a commit
to matrix-org/docker-jitsi-meet
that referenced
this pull request
Mar 27, 2024
release * a5ebb99 jibri: flag to support prometheus-style metrics (jitsi#1768) * 80fc10e feat(prosody): Cleans up gc settings. * 69bba17 feat(prosody): Adjusts lua to use generational GC for brewery.cfg.lua. * 2798426 feat(prosody): Adjusts lua to use generational GC. * 28d2b32 feat(prosody): Make sure muc tumbstones is disabled. * d5df19d jigasi: autoscaler sidecar support (jitsi#1738) * 0953ca0 jigasi: skip SIP configuration when configured as a transcriber * ca1d670 fix: 🐛 wrong quote in default config (jitsi#1761) * 360361e jibri: move xmpp config for easier override (jitsi#1748) * 452f5ba misc: working on unstable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quotes in the config for subdomain were wrong.